[PATCH] Porting to NetBSD
Peter Hofer
ph at desktopbsd.net
Thu Dec 7 20:58:16 CET 2006
Hi Raphael,
> Depending on time frame (especially with the 1.6 release) I would even like
> to do this in trunk (instead of a branch), I think there are no major
> changes (it's all BSD after all).
No objections, as long as major breakages can be avoided.
> Feel free to comment (if any). I want to make sure that the changes are ok
> before they get committed.
I had a look at your patch and would like to point out a few things I noticed:
- FreeBSD's vfsstat implementation is different from NetBSD's. getvfsstat()
does not exist on FreeBSD systems and the statvfs structure on FreeBSD
doesn't contain all members referenced in disk.cpp and mntdevice.cpp. This
actually makes the build fail on FreeBSD.
See http://netbsd.gw.com/cgi-bin/man-cgi?statvfs+5 and
http://www.freebsd.org/cgi/man.cgi?query=statvfs
- There is no real need to find an ATAPICAM replacement for NetBSD. The
purpose of isATAPICAMDevice() in mntdevice.cpp is to avoid accessing CD/DVD
drives through ATAPICAM since there are some problems, especially with
mounting DVDs.
- Feel free to replace non-standard functions like stpcpy() with a proper
implementation using strcpy() (package.cpp)
- The package manager won't work without a defined INDEX_PATH variable
(pkgconstants.h)
Other than that, everything seems to work fine on FreeBSD :)
Best regards,
Peter
More information about the Devel
mailing list